[Downstream change][libc++][test] extend XFAIL clauses to cover Amazon Linux too #171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's a cherry-pick from the main branch.
The default triple of Amazon Linux on AArch64 is aarch64-amazon-linux,
see issue highlighded by PR #109263, somewhat serious linker issues are
encountered if any other triple is being used.
Unfortunately, this makes XFAIL lines like
`XFAIL: target=aarch64{{.*}}-linux-gnu` ineffective, making it
impossible to complete all of the check-cxx on Amazon Linux without
failing.
pawosm-arm
requested review from
DaftanoPro,
DavidTruby,
dcandler,
kiranchandramohan,
pratlucas,
schander-arm and
voltur01
DaftanoPro
approved these changes
Mar 6, 2025
dcandler
requested changes
Mar 6, 2025
Contributor
dcandler
left a comment
dcandler
left a comment
There was a problem hiding this comment.
Since this is a downstream change on the branch, it should follow the Downstream Patch Policy: https://github.com/arm/arm-toolchain/blob/arm-software/CONTRIBUTING.md#downstream-patch-policy
pawosm-arm
changed the title
Contributor
Author
|
@dcandler I've changed the topic and the comment according to the Requirements for a downstream patch. |
dcandler
approved these changes
Mar 6, 2025
Contributor
dcandler
left a comment
dcandler
left a comment
There was a problem hiding this comment.
Thanks - the policy does say to annotate the sources as well but I'm not sure how strictly that is going to be enforced on the branch. Having the tracking issue is the primary requirement.
pawosm-arm
deleted the
users/pawosm-arm/release/arm-software/20.x/atfl-xfail-amzn
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a cherry-pick from the LLVM's main branch. Without this commit we cannot build ATfL for Amazon Linux 2023 in our CI. Our release cycle got effectively blocked.
Ongoing upstream attempt: llvm/llvm-project#129566
Downstream issue: #173
The default triple of Amazon Linux on AArch64 is aarch64-amazon-linux, see issue highlighded by LLVM's PR #109263, somewhat serious linker issues are encountered if any other triple is being used.
Unfortunately, this makes XFAIL lines like
XFAIL: target=aarch64{{.*}}-linux-gnuineffective, making it impossible to complete all of the check-cxx on Amazon Linux without failing.